I’m Not on the DEV Team. I Still Debugged Their Missing Badges From Public Code. (And My First Test Was Wrong.)

说明与用途

DEV 上多次提交徽章的问题通过修复 slug 不匹配、添加感谢信息以及确保幂等性得到解决。现在拥有四次或以上合并的贡献者将收到带有感谢信息的 4x‑commit‑club 徽章。

问题

Missing multi‑commit contributor badges on DEV due to slug mismatch, missing context messages, and idempotency issues in the badge awarding service.

结果

The PR fixed slug resolution, added thank‑you context, and ensured idempotent badge creation, restoring badge awards for multi‑commit contributors and preventing duplicate emails.

工作流

• 1. Observe missing badge after 4 merged PRs. 2. Inspect BadgeAwardWorker schedule and GitHub API. 3. Read award_contributor_from_github.rb to identify bugs. 4. Identify slug mismatch, missing context, and idempotency problems. 5. File Issue #24114 and submit PR #24113 with fixes. 6. Review and adjust logging and regression tests. 7. Merge PR and verify badge awarded with context message.

证据

Each key in BADGE_SLUGS is resolved via Badge.id_for_slug(slug). If a slug in the production badges table doesn’t match the hardcoded constant, id_for_slug returns nil.

来源

BadgeAchievement.create(user_id: user_id, badge_id: slug_id)

来源

I ran a read-only lookup on the badges table for the five BADGE_SLUGS keys. Only one of the five slugs resolves.

来源

The test passed on main without the fix because the badge factory defaults to allow_multiple_awards: false.

来源