I’m Not on the DEV Team. I Still Debugged Their Missing Badges From Public Code. (And My First Test Was Wrong.)
说明与用途
DEV 奖励系统中的 slug 不匹配、缺失上下文信息和无幂等性导致多次提交徽章缺失。修复代码后徽章正常显示并发送正确邮件。
问题
Missing multi‑commit contributor badges on DEV due to slug mismatch, missing context messages, and idempotency issues in the badge awarding service.
结果
The PR fixed badge awarding logic, restored missing badges, added thank‑you messages, and prevented duplicate badge emails.
工作流
- 1. Identified missing badges after merging four PRs. 2. Reviewed BadgeAwardWorker schedule and GitHub API. 3. Opened award_contributor_from_github.rb to inspect logic. 4. Discovered three bugs: silent slug drops, missing context, missing idempotency. 5. Filed Issue #24114 and PR #24113 with fixes. 6. Reviewed PR with OpenHands; adjusted logging and test. 7. Merged PR and received badge email with context message.
证据
Each key in BADGE_SLUGS is resolved via Badge.id_for_slug(slug). If a slug in the production badges table doesn't match the hardcoded constant, id_for_slug returns nil.
BadgeAchievement.create(user_id: user_id, badge_id: slug_id)
I ran a read-only lookup on the badges table for the five BADGE_SLUGS keys. Only one of the five slugs resolves.
- 记录日期: 2026-10-24T20:26:48.339Z