Loading page...Загружаем страницу...正在加载页面...
AtlasRepo

My First Merged PR in Zalando Logbook: What I Built and What the Review Taught Me

Description and use

The author added status‑code‑based logging to Zalando Logbook, merged the PR, and learned the value of early communication, small diffs, and thorough reviews.

Problem

Integrating status‑code‑based logging into Zalando Logbook to reduce noise from normal traffic while highlighting errors.

Outcome

The PR was merged, improving log clarity and teaching the author about the importance of early communication, small diffs, and thorough reviews.

Workflow

  • 1. Discussed feature with maintainers on GitHub issue to clarify requirements.
  • 2. Designed small, focused changes: StatusCodeBasedSink and LevelBasedHttpLogWriter.
  • 3. Implemented changes and wrote unit tests.
  • 4. Signed commits and opened PR #2301.
  • 5. Addressed review comments on style, compatibility, and naming.
  • 6. PR merged in May 2026.
  • 7. Reviewed subsequent PR #2379 that fixed a gap in ECS sink behavior.

Evidence

My PR added two things to Logbook: StatusCodeBasedSink and LevelBasedHttpLogWriter.

Source

I did not start by writing code. I started by talking to the maintainers on the issue, so I knew what they wanted before I built anything.

Source

Maintainers read very carefully. They do not only check if your code works. They ask: Does this fit the style of the project? Will this break anyone who is already using the library? Is the naming clear for someone who has never seen this code?

Source

After my PR was merged, another contributor found a gap in my own work. The ECS sink did not follow the same status code behavior, so he opened an issue and then a PR to fix it.

Source

  • Record date: 2026-11-02T09:14:02.798Z